Skip to content

Conversation

@pwright
Copy link
Member

@pwright pwright commented Jan 22, 2025

@nluaces does this make sense? or too broad?

Copy link
Member

@nluaces nluaces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Paul, looks good to me. I will add @c-kruse to double-check the network observer part.

@nluaces nluaces requested a review from c-kruse January 22, 2025 13:36
Copy link
Contributor

@c-kruse c-kruse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Paul! Just those two false positives made it in, but otherwise looks good to me!

@@ -1,5 +1,5 @@
package main

//go:generate go run github.com/oapi-codegen/oapi-codegen/v2/cmd/oapi-codegen --config=.oapi-codegen.cfg ./spec/openapi.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a different v2!


import (
_ "github.com/oapi-codegen/oapi-codegen/v2/cmd/oapi-codegen"
_ "github.com/oapi-codegen/oapi-codegen/main/cmd/oapi-codegen"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one also should not be changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants