Allows the Controller to delegate certificate management #2290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature enables the Skupper Controller to delegate certificate management to an external controller, allowing the controller to be defined at: * Controller startup (through: `-certificate-controller` flag or `CERTIFICATE_CONTROLLER` env var) * Through the `certificate-controller` setting for the following resources: * Site * SecuredAccess * RouterAccess * Certificate
c-kruse
reviewed
Oct 23, 2025
| } | ||
|
|
||
| func (m *SecuredAccessManager) Ensure(namespace string, name string, spec skupperv2alpha1.SecuredAccessSpec, annotations map[string]string, refs []metav1.OwnerReference) error { | ||
| func (m *SecuredAccessManager) Ensure(namespace string, name string, spec skupperv2alpha1.SecuredAccessSpec, annotations map[string]string, certificateController string, refs []metav1.OwnerReference) error { |
Contributor
There was a problem hiding this comment.
@fgiorgetti should we accept a separate certificateController arg here or just go off what's in the spec? I'm afraid this flips between what's in certificateController on create (the Site setting) to what's in spec.Settings on update (usually the RouterAccess setting.)
Member
Author
There was a problem hiding this comment.
Certainly simpler. Thanks for the catch!
fgiorgetti
force-pushed
the
certs-delegate
branch
from
f1d8db0 to
16bb572
Compare
c-kruse
approved these changes
Oct 24, 2025
Member
Author
|
Just a demo project to be used along with this PR, in order to evaluate it properly: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature enables the Skupper Controller to delegate certificate management to an external controller, allowing the controller to be defined at:
-certificate-controllerflag orCERTIFICATE_CONTROLLERenv var)certificate-controllersetting for the following resources: