Add a watcher for system input files #2334
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nluaces
force-pushed
the
2333-system-controller-input-watcher
branch
from
163082a to
853219d
Compare
fgiorgetti
reviewed
Dec 19, 2025
Member
fgiorgetti
left a comment
fgiorgetti
left a comment
There was a problem hiding this comment.
It would be nice to include a message in the startup banner of the system controller, displaying the status of the autoreload definition.
Another thing I am missing here is the fact that if you delete a Site and/or all resources from a given namespace, the Teardown is not being executed.
| "SKUPPER_OUTPUT_PATH": config.hostDataHome, | ||
| "CONTAINER_ENGINE": config.containerEngine, | ||
| "SKUPPER_SYSTEM_RELOAD_TYPE": utils.DefaultStr(os.Getenv(types.ENV_SYSTEM_AUTO_RELOAD), | ||
| types.SystemReloadTypeAuto), |
Member
There was a problem hiding this comment.
Should the default here be SystemReloadTypeManual, instead?
| types.SystemReloadTypeManual) | ||
|
|
||
| if systemReloadType == types.SystemReloadTypeManual { | ||
| slog.Default().Error("Automatic reloading is not configured.") |
Member
There was a problem hiding this comment.
Maybe make this a debug level message, not an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #2333
Changes:
SKUPPER_SYSTEM_RELOAD_TYPEto "manual"skupper system installneeds to pass said env. variable to the system-controller pod.Additional information: