Renames SAI to DAI and SKR to PETH.#113
Renames SAI to DAI and SKR to PETH.#113MicahZoltu wants to merge 1 commit intosky-ecosystem:masterfrom
Conversation
|
I did try to review the find and replace changes to make sure they didn't pick up some word with |
|
I think we want to keep "sai" at the dev level, but SKR->PETH in the documentation might be a good change |
|
I guess the README should reflect http://developer.makerdao.com/dai/1/api/ Can we first process a PR that only changes documentation? This means some places you'll need e.g. "to get PETH balance you call |
|
Personally, I think it would be even more confusing if the Readme mentions DAI/PETH but the source code all mentions SAI/SKR. My recommendation is to pick a naming convention and stick with it and be thorough in your transitions (e.g., rename it everywhere if you are going to rename it). What is the argument for leaving the code with SAI/SKR while all other documentation and user-facing material is DAI/PETH? |
|
Maybe the right answer is to just publicly rename DAI to SAI and PETH to SKR? |
This PR was generated via the following operations:
sai->daiSAI->DAIsaiin the name to havedaiin the name instead.skr->peth.SKR->PETH.skrin the name to havepethin the name instead.Unfortunately, for some of the smaller files, git sees enough of the file changed to not notice that it was a rename/move and thinks it was a deletion/addition, so they don't line up when reviewing. Locally I believe you can lower git's threshold and see if it can display diffs instead of additions/removals.