283. Move Zeroes #20
Open
283. Move Zeroes #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tokuhirat
reviewed
Aug 24, 2025
|
|
||
| for i in range(non_zero_pos, len(nums)): | ||
| nums[i] = 0 | ||
| ``` |
ryosuketc
reviewed
Aug 25, 2025
| ```py | ||
| class Solution: | ||
| def moveZeroes(self, nums: List[int]) -> None: | ||
| non_zero_pos = 0 |
There was a problem hiding this comment.
pos よりも index の方が馴染みがあるようには思いますが、好みの範囲かと思います。
| * https://github.com/fhiyo/leetcode/pull/54 | ||
| - Python | ||
| - `nonzeros` に非ゼロな値をコピーして退避し、それを`nums` に追加していく方法 | ||
| - （コピー作成してもOKなんだ…） |
There was a problem hiding this comment.
これはコピーしても ok というか、補助的なリスト (nonzeros) を用意して、最終的には nums を mutate していますね。コピーしたリストを返しているわけではないので、念のためコメントさせてください。
nodchip
reviewed
Aug 26, 2025
| nums_len = len(nums) | ||
| for _ in range(nums_len): | ||
| if nums[nums_i] == 0: | ||
| nums.pop(nums_i) |
There was a problem hiding this comment.
list の末尾以外の要素に対して pop() を呼び出すと、それより後の要素を手前にずらさなければならないため、時間計算量 O(n) がかかり、重くなります。原則避けることをおすすめします。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
283. Move Zeroes
次回予告: 349. Intersection of Two Arrays