Move starred repositories to bookmarks screen#734
Conversation
|
Myself I would prefer to have this as a separate entry in the drawer as seen in #578. But decided to create this pull request to hear your opinions. |
|
I would prefer this implementation because, as I said in #695, I think scrollable navigation drawers are terrible ux:
|
|
I don't necessarily agree to the scrolling drawer argument (we have a lot of stuff to show, so we probably won't be able to avoid having a scrolling drawer - it's already scrolling in @Tunous example), but I think this implementation is fine, given that having a 'My repositories' + a 'Starred repositories' drawer item is somewhat inconsistent and potentially confusing as well. |
Also in @Tunous's example, if |
|
I just noticed via #684 that this PR in its current state loses sort order options. |
|
Is it OK to add it as submenu similar to the one for filtering notifications? I think that will fit better than right-side menu. |
|
Yeah, it surely is. |
f99409d to
1a36a67
Compare
|
Added. |
|
@maniac103 perhaps it's time to decide on what to do with this. I think the option I mentioned here is the way to go. (I can do the merging) |
|
This one is fine with me; I have more issues with #725. |
Related to #578, #624 and #725