feat: 검색 기능 구현 #130
Merged
feat: 검색 기능 구현 #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
bbbbooo
approved these changes
Dec 26, 2024
Comment on lines
+46
to
+83
| if( searchField.equals(SearchField.USER_NAME.getValue()) ){ | ||
| List<User> searchedUsers = userRepository.findByNameContains(keyword); | ||
| if(searchedUsers.isEmpty()) throw new SearchException(ErrorStatus.toErrorStatus("유저에 대한 검색 결과가 없습니다.", NOT_FOUND)); | ||
|
|
||
| List<ReadSearchResponse> responses = searchedUsers.stream() | ||
| .map(user -> { | ||
| List<Goal> goals = user.getGoals(); | ||
| List<ReadGoalSearchResponse> goalsResponses = goals.stream() | ||
| .map(ReadGoalSearchResponse::from) | ||
| .toList(); | ||
|
|
||
| return ReadSearchResponse.from(user, goalsResponses); | ||
| }).toList(); | ||
| return responses; | ||
|
|
||
| }else if(searchField.equals(SearchField.GOAL_TITLE.getValue())){ | ||
| List<Goal> searchedGoals = goalRepository.findByGoalTitleContains(keyword); | ||
| if(searchedGoals.isEmpty()) throw new SearchException(ErrorStatus.toErrorStatus("목표에 대한 검색 결과가 없습니다.", NOT_FOUND)); | ||
|
|
||
| Map<User, List<Goal>> userGoalsMap = searchedGoals.stream() | ||
| .collect(Collectors.groupingBy(Goal::getUser)); | ||
|
|
||
| List<ReadSearchResponse> responses = userGoalsMap.entrySet().stream() | ||
| .map(entry -> { | ||
| User user = entry.getKey(); | ||
| List<Goal> goals = entry.getValue(); | ||
|
|
||
| List<ReadGoalSearchResponse> goalsResponses = goals.stream() | ||
| .map(ReadGoalSearchResponse::from) | ||
| .toList(); | ||
|
|
||
| return ReadSearchResponse.from(user, goalsResponses); | ||
|
|
||
| }).toList(); | ||
| return responses; | ||
| }else{ | ||
| throw new SearchException(ErrorStatus.toErrorStatus("해당 필드로는 검색할 수 없습니다", BAD_REQUEST)); | ||
| } |
Member
There was a problem hiding this comment.
현재 코드에서는 SearchField 조건이 추가될 경우 else if를 사용해야 해서 코드 복잡도가 증가할거같아요.
검색 조건별로 코드를 별도의 클래스로 분리하여, 조건에 따라 실행할 로직을 동적으로 결정할 수 있는 구조는 어떻게 생각하시나요? 전략 패턴과 유사한 느낌입니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
목표로 검색하는 경우 검색어가 포함된 목표가 여러개가 있으면 유저와 목표를 여러번 반환하는 문제가 있었습니다.
그래서
Map을 사용해 검색 결과 목표가 여러개더라도 유저가 같으면 한 번만 반환하도록 하였습니다.유저명,목표명으로 딱 두 개라서enum을 사용해 안정성을 높였습니다.스크린샷 (선택)
💬리뷰 요구사항(선택)