Skip to content

fix: forward signals to child process in binary launcher #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fberlakovich wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: forward signals to child process in binary launcher #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a60066d
fix: forward signals to child process in binary launcher
Jan 13, 2026
c7a1f6e
Add signal forwarding to claudeLocal.ts
Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions scripts/claude_version_utils.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,6 +497,18 @@ function runClaudeCli(cliPath) {
stdio: 'inherit',
env: process.env
});

// Forward signals to child process so it gets killed when parent is killed
// This prevents orphaned Claude processes when switching between local/remote modes
const forwardSignal = (signal) => {
if (child.pid && !child.killed) {
child.kill(signal);
}
};
process.on('SIGTERM', () => forwardSignal('SIGTERM'));
process.on('SIGINT', () => forwardSignal('SIGINT'));
process.on('SIGHUP', () => forwardSignal('SIGHUP'));

child.on('exit', (code) => {
process.exit(code || 0);
});
Expand Down
22 changes: 22 additions & 0 deletions src/claude/claudeLocal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,28 @@ export async function claudeLocal(opts: {
env,
});

// Forward signals to child process to prevent orphaned processes
// Note: signal: opts.abort handles programmatic abort (mode switching),
// but direct OS signals (e.g., kill, Ctrl+C) need explicit forwarding
const forwardSignal = (signal: NodeJS.Signals) => {
if (child.pid && !child.killed) {
child.kill(signal);
}
};
const onSigterm = () => forwardSignal('SIGTERM');
const onSigint = () => forwardSignal('SIGINT');
const onSighup = () => forwardSignal('SIGHUP');
process.on('SIGTERM', onSigterm);
process.on('SIGINT', onSigint);
process.on('SIGHUP', onSighup);

// Cleanup signal handlers when child exits to avoid leaks
child.on('exit', () => {
process.off('SIGTERM', onSigterm);
process.off('SIGINT', onSigint);
process.off('SIGHUP', onSighup);
});

// Listen to the custom fd (fd 3) for thinking state tracking
if (child.stdio[3]) {
const rl = createInterface({
Expand Down