fix(web): preserve machine/path selection in new session screen #324
+30
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On web, the NewSessionScreen component could be unmounted during navigation to picker screens, causing the module-level callback handlers to be reset to empty functions. This resulted in machine and path selections being lost when returning from picker screens. Fix by using URL parameters to pass selections back from picker screens, which works reliably even when components are remounted. The callback mechanism is kept for native platforms where it works. Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On web, the NewSessionScreen component could be unmounted during navigation to picker screens, causing the module-level callback handlers to be reset to empty functions. This resulted in machine and path selections being lost when returning from picker screens.
Fix by using URL parameters to pass selections back from picker screens, which works reliably even when components are remounted. The callback mechanism is kept for native platforms where it works.
Generated with Claude Code via Happy