Skip to content

Conversation

@friedemannf
Copy link
Member

No description provided.

# Conflicts:
#	build/devenv/go.mod
#	build/devenv/go.sum
# Conflicts:
#	build/devenv/cciptestinterfaces/interface.go
#	build/devenv/environment.go
#	build/devenv/evm/impl.go
#	build/devenv/go.mod
# Conflicts:
#	.gitignore
#	build/devenv/cldf.go
#	build/devenv/environment.go
#	build/devenv/go.mod
@github-actions
Copy link

Code coverage report:

Package main canton diff
github.com/smartcontractkit/chainlink-ccv/aggregator 48.36% 48.39% +0.03%
github.com/smartcontractkit/chainlink-ccv/cmd 0.00% 0.00% +0.00%
github.com/smartcontractkit/chainlink-ccv/committee 100.00% 100.00% +0.00%
github.com/smartcontractkit/chainlink-ccv/common 0.00% 0.00% +0.00%
github.com/smartcontractkit/chainlink-ccv/executor 49.21% 49.21% +0.00%
github.com/smartcontractkit/chainlink-ccv/indexer 38.37% 38.34% -0.03%
github.com/smartcontractkit/chainlink-ccv/integration 46.51% 46.51% +0.00%
github.com/smartcontractkit/chainlink-ccv/pkg 100.00% 100.00% +0.00%
github.com/smartcontractkit/chainlink-ccv/pricer 39.76% 39.76% +0.00%
github.com/smartcontractkit/chainlink-ccv/protocol 54.58% 54.58% +0.00%
github.com/smartcontractkit/chainlink-ccv/verifier 58.12% 58.22% +0.10%

Comment on lines +125 to +126
// Family returns the family of the chain.
Family() string
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are both Family() and ChainFamily() needed?

Comment on lines +158 to +162
[[blockchains]]
type = "canton"
chain_id = "LocalNet"
number_of_canton_validators = 5
port = "8088"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may increase CI time for the smoke test significantly and is currently not needed - we can create a new config for Canton/EVM until we figure out how to best set up the test matrices for the full E2E tests.


replace github.com/smartcontractkit/chainlink-canton-internal => ../../../chainlink-canton-internal

replace github.com/digital-asset/dazl-client/v8 => github.com/noders-team/dazl-client/v8 v8.7.1-2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this give us something the OG github.com/digital-asset/dazl-client/v8 dep doesn't?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC it was failing due to the upstream stubs being out of date


replace github.com/smartcontractkit/chainlink-ccv/deployments => ../../deployments

replace github.com/smartcontractkit/chainlink-canton-internal => ../../../chainlink-canton-internal
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is needed for this PR, so we can probably rm

rpcHTTPURL := b.Out.Nodes[0].ExternalHTTPUrl

d, err := chainsel.GetChainDetailsByChainIDAndFamily(chainID, chainsel.FamilyEVM)
family, err := blockchain.TypeToFamily(b.Type)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can just switch on b.Family - if thats incorrect then its just wrong config.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically they're two different consts - they match 1:1 right now but ideally CTF would just re-use the chainselector constants

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants