-
Notifications
You must be signed in to change notification settings - Fork 2
Add Canton Support #577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Canton Support #577
Conversation
# Conflicts: # build/devenv/go.mod # build/devenv/go.sum
# Conflicts: # build/devenv/cciptestinterfaces/interface.go # build/devenv/environment.go # build/devenv/evm/impl.go # build/devenv/go.mod
# Conflicts: # .gitignore # build/devenv/cldf.go # build/devenv/environment.go # build/devenv/go.mod
|
Code coverage report:
|
| // Family returns the family of the chain. | ||
| Family() string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are both Family() and ChainFamily() needed?
| [[blockchains]] | ||
| type = "canton" | ||
| chain_id = "LocalNet" | ||
| number_of_canton_validators = 5 | ||
| port = "8088" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may increase CI time for the smoke test significantly and is currently not needed - we can create a new config for Canton/EVM until we figure out how to best set up the test matrices for the full E2E tests.
|
|
||
| replace github.com/smartcontractkit/chainlink-canton-internal => ../../../chainlink-canton-internal | ||
|
|
||
| replace github.com/digital-asset/dazl-client/v8 => github.com/noders-team/dazl-client/v8 v8.7.1-2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this give us something the OG github.com/digital-asset/dazl-client/v8 dep doesn't?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC it was failing due to the upstream stubs being out of date
|
|
||
| replace github.com/smartcontractkit/chainlink-ccv/deployments => ../../deployments | ||
|
|
||
| replace github.com/smartcontractkit/chainlink-canton-internal => ../../../chainlink-canton-internal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is needed for this PR, so we can probably rm
| rpcHTTPURL := b.Out.Nodes[0].ExternalHTTPUrl | ||
|
|
||
| d, err := chainsel.GetChainDetailsByChainIDAndFamily(chainID, chainsel.FamilyEVM) | ||
| family, err := blockchain.TypeToFamily(b.Type) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can just switch on b.Family - if thats incorrect then its just wrong config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
technically they're two different consts - they match 1:1 right now but ideally CTF would just re-use the chainselector constants
No description provided.