CI: repo hygiene checks

.github/workflows/golangci-lint.yaml

@@ -17,17 +17,11 @@ jobs:
         with:
           fetch-depth: 0
 
-      - name: Read Go version
-        id: tool_versions
-        shell: bash
-        run: |
-          echo "go_version=$(grep -E '^VERSION_GO=' tool-versions.env | cut -d= -f2)" >> $GITHUB_OUTPUT
-
       - name: Set up Go
         uses: actions/setup-go@v6 # v6
         with:
           cache: true
-          go-version: ${{ steps.tool_versions.outputs.go_version }}
+          go-version-file: 'go.mod'
 
       - name: Load tool versions
         id: tool-versions

.github/workflows/mod-tidy-all.yaml

@@ -16,17 +16,11 @@ jobs:
         with:
           fetch-depth: 0
 
-      - name: Read Go version
-        id: tool_versions
-        shell: bash
-        run: |
-          echo "go_version=$(grep -E '^VERSION_GO=' tool-versions.env | cut -d= -f2)" >> $GITHUB_OUTPUT
-
       - name: Set up Go
         uses: actions/setup-go@v6 # v6
         with:
           cache: true
-          go-version: ${{ steps.tool_versions.outputs.go_version }}
+          go-version-file: 'go.mod'
 
       - name: Populate go envs
         run: |

.github/workflows/release-rc-publish.yaml

@@ -19,8 +19,6 @@ jobs:
 
       - name: Install Just
         uses: extractions/setup-just@e33e0265a09d6d736e2ee1e0eb685ef1de4669ff # v3
-        with:
-          just-version: '1.40.0'
 
       - name: Authenticate to AWS ECR
         uses: ./.github/actions/aws-ecr-auth
@@ -40,4 +38,4 @@ jobs:
           echo "Building Release Candidate Image.."
           just "$MODULE"/build-rc
           echo "Publishing Release Candidate Image.."
-          just "$MODULE"/publish-rc "${{ secrets.ECR_REGISTRY }}" "$VERSION"
+          just "$MODULE"/publish-rc "${{ secrets.ECR_REGISTRY }}" "$VERSION"

.github/workflows/repo-hygiene.yaml

@@ -0,0 +1,32 @@
+name: Repo Hygiene Checks
+
+on:
+  merge_group:
+  pull_request:
+  push:
+    branches:
+      - main
+
+jobs:
+  hygiene-checks:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v5
+        with:
+          fetch-depth: 0
+
+      - name: Set up Go
+        uses: actions/setup-go@v6 # v6
+        with:
+          cache: true
+          go-version-file: 'go.mod'
+
+      - name: Install just
+        uses: extractions/setup-just@69d82fb0233557aec017ef13706851d0694e0f1d # v2.0.0
+
+      - name: Install go-tools
+        run: just install-go-tools
+
+      - name: Run repo hygiene checks
+        run: tools/bin/check_repo_clean.sh tidy mock generate shellcheck

.github/workflows/test-nightly-performance-chaos.yaml

@@ -37,8 +37,6 @@ jobs:
 
       - name: Install Just
         uses: extractions/setup-just@e33e0265a09d6d736e2ee1e0eb685ef1de4669ff # v3
-        with:
-          just-version: '1.40.0'
 
       - name: Authenticate to AWS ECR
         uses: ./.github/actions/aws-ecr-auth
@@ -78,4 +76,4 @@ jobs:
         env:
           LOKI_URL: http://localhost:3030/loki/api/v1/push
         run: |
-          go test -v -run ${{ matrix.test.name }} -timeout 1h
+          go test -v -run ${{ matrix.test.name }} -timeout 1h

.github/workflows/test-performance-on-demand.yaml

@@ -37,16 +37,14 @@ jobs:
 
       - name: Install Just
         uses: extractions/setup-just@e33e0265a09d6d736e2ee1e0eb685ef1de4669ff # v3
-        with:
-          just-version: '1.40.0'
 
       - name: Authenticate to AWS ECR
         uses: ./.github/actions/aws-ecr-auth
         with:
           role-to-assume: ${{ secrets.CCV_IAM_ROLE }}
           aws-region: us-east-1
           registry-type: public
-      
+
       - name: Authenticate to AWS ECR (JD)
         uses: ./.github/actions/aws-ecr-auth
         with:
@@ -86,4 +84,4 @@ jobs:
         env:
           LOKI_URL: http://localhost:3030/loki/api/v1/push
         run: |
-          go test -v -run ${{ matrix.test.name }} -timeout 1h
+          go test -v -run ${{ matrix.test.name }} -timeout 1h

.github/workflows/test-services.yaml

@@ -29,8 +29,6 @@ jobs:
 
       - name: Install Just
         uses: extractions/setup-just@e33e0265a09d6d736e2ee1e0eb685ef1de4669ff # v3
-        with:
-          just-version: '1.40.0'
 
       - name: Authenticate to AWS ECR
         uses: ./.github/actions/aws-ecr-auth

.github/workflows/test-smoke.yaml

@@ -57,16 +57,14 @@ jobs:
 
       - name: Install Just
         uses: extractions/setup-just@e33e0265a09d6d736e2ee1e0eb685ef1de4669ff # v3
-        with:
-          just-version: '1.40.0'
 
       - name: Authenticate to AWS ECR
         uses: ./.github/actions/aws-ecr-auth
         with:
           role-to-assume: ${{ secrets.CCV_IAM_ROLE }}
           aws-region: us-east-1
           registry-type: public
-          
+
       - name: Authenticate to AWS ECR (JD)
         uses: ./.github/actions/aws-ecr-auth
         with:

.github/workflows/test-testnets-integration.yaml

@@ -31,16 +31,14 @@ jobs:
 
       - name: Install Just
         uses: extractions/setup-just@e33e0265a09d6d736e2ee1e0eb685ef1de4669ff # v3
-        with:
-          just-version: '1.40.0'
 
       - name: Authenticate to AWS ECR
         uses: ./.github/actions/aws-ecr-auth
         with:
           role-to-assume: ${{ secrets.CCV_IAM_ROLE }}
           aws-region: us-east-1
           registry-type: public
-      
+
       - name: Authenticate to AWS ECR (JD)
         uses: ./.github/actions/aws-ecr-auth
         with:
@@ -83,4 +81,4 @@ jobs:
 
       - name: Run Soak Test
         working-directory: build/devenv/tests/e2e
-        run: go test -timeout 2h -v -run TestSoak
+        run: go test -timeout 2h -v -run TestSoak

Justfile

@@ -51,6 +51,13 @@ fmt: ensure-golangci-lint
 lint fix="": ensure-golangci-lint
     find . -type f -name go.mod -execdir golangci-lint run {{ if fix != "" { "--fix" } else { "" } }} \;
 
+shellcheck:
+    @command -v shellcheck >/dev/null 2>&1 || { \
+        echo "shellcheck is not installed. Please install it first."; \
+        exit 1; \
+    }
+    find . -type f -name *.sh -execdir shellcheck {} +
+
 mod-download: ensure-go
     go mod download
 

indexer/docs/.openapi-generator/VERSION

@@ -1 +1 @@
-7.20.0-SNAPSHOT
+7.19.0

indexer/generate-docs.sh

@@ -1,7 +1,7 @@
 #!/usr/bin/env bash
 docker run --rm \
   -v "${PWD}:/local" \
-  openapitools/openapi-generator-cli generate \
+  openapitools/openapi-generator-cli:v7.19.0 generate \
   -i /local/indexer_opanapi_v1.yaml \
   -g markdown \
   -o /local/docs

tools/bin/check_repo_clean.sh

@@ -0,0 +1,67 @@
+#!/usr/bin/env bash
+set -euo pipefail
+
+# Script to run repository hygiene commands and fail if they modify the repo.
+# Exits non-zero and prints modified files if any step fails or changes the working tree.
+
+# Default list of just targets to run for checks (fallback).
+just_targets_to_run=(tidy mock generate shellcheck)
+
+# If the script is invoked with positional arguments, use those as the targets
+# instead of the default list. Example:
+#   ./tools/bin/check_repo_clean.sh tidy mock generate
+if [ "$#" -gt 0 ]; then
+  just_targets_to_run=("$@")
+fi
+
+# Ensure we are inside a git repository
+if ! git rev-parse --is-inside-work-tree >/dev/null 2>&1; then
+  echo "ERROR: not inside a git repository" >&2
+  exit 2
+fi
+
+# Ensure `just` is available
+if ! command -v just >/dev/null 2>&1; then
+  echo "ERROR: 'just' not found in PATH" >&2
+  exit 2
+fi
+
+run_and_check() {
+  local before
+  local after
+
+  echo "--- Running: just $* ---"
+  before=$(git status --porcelain)
+
+  if ! just "$@"; then
+    echo "ERROR: 'just $*' failed" >&2
+    exit 1
+  fi
+
+  after=$(git status --porcelain)
+
+  if [ "${before}" != "${after}" ]; then
+    echo ""
+    echo "ERROR: Repository changed after 'just $*'." >&2
+    echo "Changed files (git status --porcelain):" >&2
+    git --no-pager status --porcelain >&2
+    echo ""
+    echo "You should inspect and commit or revert these changes." >&2
+    exit 1
+  fi
+
+  echo "OK: no repo changes after 'just $*'."
+  echo ""
+}
+
+for c in "${just_targets_to_run[@]}"; do
+  run_and_check "$c"
+done
+
+# Print a multiline bulleted list showing which just targets ran
+echo "All checks passed:"
+for t in "${just_targets_to_run[@]}"; do
+  echo "    * just $t"
+done
+
+exit 0

tools/bin/cov_compare.sh

@@ -23,7 +23,7 @@ for arg in "$@"; do
 done
 
 # Reset positional parameters
-set -- $ARGS
+set -- "$ARGS"
 
 if [ "$#" -ne 2 ]; then
   echo "Usage: $0 [--no-header] coverage1.out coverage2.out" >&2

tools/bin/install-protoc.sh

@@ -13,7 +13,7 @@ os=$(uname)
 arch=$(uname -m)
 
 install_dir=/usr/local
-$install_dir/bin/protoc --version | grep $VERSION
+$install_dir/bin/protoc --version | grep "$VERSION"
 rc=$?
 if [ $rc -eq 0 ]; then
     # we have the current VERSION
@@ -38,12 +38,12 @@ else
 fi
 
 workdir=$(mktemp -d)
-pushd $workdir
+pushd "$workdir" || exit 1
 pb_url="https://github.com/protocolbuffers/protobuf/releases"
 artifact=protoc-$VERSION-$os-$arch.zip
-curl -LO $pb_url/download/v${VERSION}/$artifact
-unzip -o $artifact -d $install_dir
-rm $artifact
+curl -LO "$pb_url/download/v${VERSION}/$artifact"
+unzip -o "$artifact" -d "$install_dir"
+rm "$artifact"
 
 echo "protoc $VERSION installed in $install_dir"
-popd
+popd || exit 1