Coreshim WIP #1786
Closed
Coreshim WIP #1786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedric-cordenier
temporarily deployed
to
integration
GitHub Actions
Inactive
cedric-cordenier
temporarily deployed
to
integration
GitHub Actions
Inactive
cedric-cordenier
temporarily deployed
to
integration
GitHub Actions
Inactive
✅ API Diff Results - No breaking changes |
cedric-cordenier
force-pushed
the
coreshim-add-csa
branch
from
bada55f to
095bfee
Compare
cedric-cordenier
temporarily deployed
to
integration
GitHub Actions
Inactive
cedric-cordenier
temporarily deployed
to
integration
GitHub Actions
Inactive
cedric-cordenier
temporarily deployed
to
integration
GitHub Actions
Inactive
- Added ChainType field to OCRKeyBundle struct - Extract chain type from onchain key path using NewKeyPathFromString - Use chainTypeEVM constant instead of hardcoded "EVM" string - Parse key name and extract chain type from path in FromEncryptedOCRKeyBundle
cedric-cordenier
temporarily deployed
to
integration
GitHub Actions
Inactive
cedric-cordenier
temporarily deployed
to
integration
GitHub Actions
Inactive
cedric-cordenier
temporarily deployed
to
integration
GitHub Actions
Inactive
jmank88
reviewed
Jan 22, 2026
| "github.com/smartcontractkit/chainlink-common/keystore/ocr2offchain" | ||
| ) | ||
|
|
||
| type ChainType string |
Contributor
There was a problem hiding this comment.
Any chance that we can reuse one of the existing chain family types?
Contributor
Author
There was a problem hiding this comment.
I wasn't able to find any in common 🤔 Do you know where we define them?
Alternatively I can move the chain types in core to common and depend on that here
jmank88
reviewed
Jan 22, 2026
Contributor
Author
|
Superceded by #1793 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires
Supports