Move chaintype package to common #1795
Conversation
|
👋 cedric-cordenier, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
cedric-cordenier
had a problem deploying
to
integration
GitHub Actions
Error
cedric-cordenier
had a problem deploying
to
integration
GitHub Actions
Error
cedric-cordenier
had a problem deploying
to
integration
GitHub Actions
Error
There was a problem hiding this comment.
Pull request overview
This PR moves the chaintype package to a common location to enable its use in the corekeys package. The change involves creating a new chaintype package with types and utilities for managing different blockchain types.
Changes:
- Introduces a new
chaintypepackage withChainTypestring type and constants for supported chains (EVM, Cosmos, Solana, StarkNet, Aptos, Tron, TON, Sui, Offchain) - Implements conversion functions between
ChainTypeand numeric representations - Provides validation utilities for supported chain types
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
✅ API Diff Results - No breaking changes |
cedric-cordenier
had a problem deploying
to
integration
GitHub Actions
Error
cedric-cordenier
had a problem deploying
to
integration
GitHub Actions
Error
cedric-cordenier
had a problem deploying
to
integration
GitHub Actions
Error
cedric-cordenier
force-pushed
the
chaintype-pkg
branch
from
baad729 to
1bcf679
Compare
cedric-cordenier
temporarily deployed
to
integration
GitHub Actions
Inactive
cedric-cordenier
temporarily deployed
to
integration
GitHub Actions
Inactive
cedric-cordenier
had a problem deploying
to
integration
GitHub Actions
Failure
| ) | ||
|
|
||
| // ChainType denotes the chain or network to work with | ||
| type ChainType string |
There was a problem hiding this comment.
Don't we have a chain family enum for this somewhere in common already?
There was a problem hiding this comment.
I can't find one exactly, but we use string fields and reference chain selector consts in a few places. Could we do that here too?
There was a problem hiding this comment.
Hmmm let me take a look at the chain selector consts to see if that'll work.
Wdym by string fields though? Can I point me to an example?
There was a problem hiding this comment.
Ah looks like I can just use FamilyEVM in chain-selectors? Is that what you had in mind?
2 participants
This is needed to use these types in the corekeys package which I'm creating atm.