[CRE-491] Move EVM relay read files from core #341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
✅ API Diff Results - No breaking changes |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR moves EVM relay read-related files from the chainlink core repository to chainlink-evm as part of dependency refactoring work.
Changes:
- Adds batch calling infrastructure with dynamic limit retry logic for EVM RPC calls
- Introduces bindings registry system for managing contract readers and event bindings
- Implements multi-event type querying capabilities
- Adds CCIP v1.6.0 gobindings (onramp/offramp) for optimized event decoding
- Includes comprehensive error handling and filtering mechanisms
Reviewed changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/read/batch.go | Implements batch caller with dynamic retry and parallel execution support |
| pkg/read/bindings.go | Provides bindings registry for managing contract readers and addresses |
| pkg/read/contract.go | Manages contract-level bindings and filter registration |
| pkg/read/event.go | Core event binding implementation with log decoding and filtering |
| pkg/read/method.go | Method binding for contract read operations |
| pkg/read/multieventtype.go | Multi-event type query support with validation |
| pkg/read/filter.go | Synced filter management for log poller registration |
| pkg/read/errors.go | Custom error types for read operations |
| pkg/read/lookup.go | Read identifier lookup utilities |
| pkg/read/bindings/offramp/offramp.go | CCIP v1.6.0 offramp gobindings |
| pkg/read/bindings/onramp/onramp.go | CCIP v1.6.0 onramp gobindings |
| pkg/read/mocks/*.go | Generated mock implementations |
| pkg/read/*_test.go | Test coverage for batch caller, bindings, events, and multi-event types |
| go.mod | Adds chainlink-protos/cre/go and golang.org/x/sync dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| func Test_DecodeHardcodedType(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| t.Run("decode hardcoded type offramp CoommitReportAccess success", func(t *testing.T) { |
There was a problem hiding this comment.
Corrected spelling of 'CoommitReportAccess' to 'CommitReportAccess'.
Suggested change
| t.Run("decode hardcoded type offramp CoommitReportAccess success", func(t *testing.T) { | |
| t.Run("decode hardcoded type offramp CommitReportAccess success", func(t *testing.T) { |
| require.True(t, bytes.Equal(fixtLog.Message.FeeToken.Bytes(), out.Message.FeeToken[:])) | ||
| require.Len(t, out.Message.TokenAmounts, len(fixtLog.Message.TokenAmounts)) | ||
| }) | ||
| t.Run("decode hardcoded tupe offramp ExecutionStateChange success", func(t *testing.T) { |
There was a problem hiding this comment.
Corrected spelling of 'tupe' to 'type'.
Suggested change
| t.Run("decode hardcoded tupe offramp ExecutionStateChange success", func(t *testing.T) { | |
| t.Run("decode hardcoded type offramp ExecutionStateChange success", func(t *testing.T) { |
| func convertOnRampCCIPMessage(m onramp.InternalEVM2AnyRampMessage) ccipocr3.Message { | ||
| var out ccipocr3.Message | ||
|
|
||
| // header population. NOTE OnRamp and MsgHash will be populater by the CR caller |
There was a problem hiding this comment.
Corrected spelling of 'populater' to 'populated'.
Suggested change
| // header population. NOTE OnRamp and MsgHash will be populater by the CR caller | |
| // header population. NOTE OnRamp and MsgHash will be populated by the CR caller |
jmank88
approved these changes
Jan 26, 2026
george-dorin
approved these changes
Jan 26, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports smartcontractkit/chainlink#20929