Split MetaClient errors from standard RPC errors #343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
cll-gg
reviewed
Jan 30, 2026
| return a.c.PendingNonceAt(ctx, address) | ||
| } | ||
|
|
||
| // SendTransactions handles three diffenent cases: |
Contributor
There was a problem hiding this comment.
Suggested change
| // SendTransactions handles three diffenent cases: | |
| // SendTransactions handles three different cases: |
cll-gg
reviewed
Jan 30, 2026
Comment on lines
+183
to
+204
| if !tx.IsPurgeable { | ||
| if meta != nil && | ||
| meta.DualBroadcast != nil && *meta.DualBroadcast && meta.DualBroadcastParams != nil && meta.FwdrDestAddress != nil && | ||
| tx.AttemptCount == 1 { | ||
| meta, err := a.SendRequest(ctx, tx, attempt, *meta.DualBroadcastParams, tx.ToAddress) | ||
| if err != nil { | ||
| a.metrics.RecordSendRequestError(ctx) | ||
| return fmt.Errorf("error sending request for transactionID(%d): %w", tx.ID, ErrAuction) | ||
| } | ||
| return nil | ||
| if meta != nil { | ||
| if err := a.SendOperation(ctx, tx, attempt, *meta); err != nil { | ||
| a.metrics.RecordSendOperationError(ctx) | ||
| return fmt.Errorf("failed to send operation for transactionID(%d): %w", tx.ID, ErrAuction) | ||
| } | ||
| return nil | ||
| } | ||
| a.lggr.Infof("No bids for transactionID(%d): ", tx.ID) | ||
| return ErrNoBids | ||
| } | ||
| if len(tx.Attempts) > 1 { | ||
| a.lggr.Infow("Intercepted attempt for tx(rebroadcasting first attempt)", "txID", tx.ID, "attempt", tx.Attempts[0]) | ||
| return a.c.SendTransaction(ctx, tx.Attempts[0].SignedTransaction) |
Contributor
There was a problem hiding this comment.
Maybe it's me, but I find it hard to reason about this many ifs. Is there any way to make this less indented, maybe through an early return?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR distinguishes the errors returned by the MetaClient from the standard RPC errors and marks as fatal the former. Additionally, it for the RPC errors it now rebroadcasts a past attempt instead of reauctioning.