Skip to content

CRE-1647: refactor #20855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mchain0 merged 9 commits into from
Jan 29, 2026
Merged

CRE-1647: refactor #20855

mchain0 merged 9 commits into from
Jan 29, 2026

Conversation

@mchain0
Copy link
Contributor

@mchain0 mchain0 commented Jan 21, 2026 •
edited by atlassian bot
Loading

moving sharding services from common to core for better organization and easier development

CRE-1647

merged before:

@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2026

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@trunk-io
Copy link

trunk-io bot commented Jan 21, 2026 •
edited
Loading

Static Badge   Static Badge   Static Badge   Static Badge

View Full Report ↗︎ ⋅ Docs

@mchain0 mchain0 mentioned this pull request Jan 28, 2026
Merged
@mchain0 mchain0 mentioned this pull request Jan 29, 2026
Merged
@mchain0 mchain0 requested review from agparadiso and bolekk January 29, 2026 10:49
@cl-sonarqube-production
Copy link

cl-sonarqube-production bot commented Jan 29, 2026

Quality Gate passed Quality Gate passed

Issues
0 New issues
7 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@mchain0 mchain0 marked this pull request as ready for review January 29, 2026 11:58
@mchain0 mchain0 requested review from a team as code owners January 29, 2026 11:58
@mchain0 mchain0 added this pull request to the merge queue Jan 29, 2026
Merged via the queue into develop with commit d3c72b0 Jan 29, 2026
398 of 402 checks passed
@mchain0 mchain0 deleted the cre-1647-reorganize-ring-to-core branch January 29, 2026 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cedric-cordenier cedric-cordenier cedric-cordenier approved these changes

@chudilka1 chudilka1 chudilka1 approved these changes

@bolekk bolekk Awaiting requested review from bolekk

@agparadiso agparadiso Awaiting requested review from agparadiso

@ChrisAmora ChrisAmora Awaiting requested review from ChrisAmora

@george-dorin george-dorin Awaiting requested review from george-dorin

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mchain0 @cedric-cordenier @chudilka1