feat: add release command and ask-questions skill

[fdematos]

Summary

• add /release command to guide release workflow with safeguards
• replace the code-release skill with command-based docs and add the ask-questions skill
• show a toast when loading skills while logging failures

Testing

• npm run test

[opencode-agent]

Code Review Comments

command/release.md

1. Code Quality: The command documentation is well-structured and clear. The use of frontmatter and markdown formatting is consistent with the project's conventions.

2. Potential Bugs:

   • Line 7-9: The shell commands use ! prefix which might not be supported in all contexts. Consider using a more explicit syntax or documenting this requirement.
   • Line 13-17: The "CRITICAL CONSTRAINT" section lists actions that require confirmation, but there's no explicit mention of how these confirmations should be implemented or handled in the code.

3. Suggestions for Improvement:

   • Add examples of how to handle user confirmation in the implementation.
   • Consider adding error handling guidance for cases where version detection fails.

skill/ask-questions-if-underspecified/SKILL.md

1. Code Quality: The skill documentation is comprehensive and follows good practices for skill definition. The structure is clear with well-defined sections.

2. Potential Bugs: None identified.

3. Suggestions for Improvement:

   • Consider adding more concrete examples of when to use this skill vs. when to proceed with discovery reads.
   • The "Anti-patterns" section could benefit from specific examples of what constitutes a "quick, low-risk discovery read".

src/index.ts

1. Code Quality: The changes are minimal (only +1 line) and maintain the existing code style. The addition of the "release" command to the tools list is appropriate.

2. Potential Bugs: None identified in the changes.

3. Suggestions for Improvement: None needed for this specific change.

src/tools/skill.ts

1. Code Quality: The changes are well-implemented. The toast notification feature is a good UX improvement.

2. Potential Bugs:

   • Lines 193-202: The toast notification is wrapped in a try-catch, but there's no fallback behavior if it fails. Consider logging this more prominently or providing alternative feedback.
   • The error handling in loadSkillContent (line 117-119) silently skips invalid skill files, which might make debugging difficult.

3. Suggestions for Improvement:

   • Consider adding more detailed error logging when skill loading fails.
   • The toast duration of 3000ms (line 197) might be too short for users to notice. Consider making this configurable or slightly longer.

General Comments

1. The pull request accomplishes its stated goals of adding the release command and ask-questions skill.
2. The changes maintain good code quality and follow existing patterns.
3. The toast notification feature in the skill tool is a nice UX improvement.
4. Consider adding more comprehensive error handling and logging for production use.
5. The documentation in both new files is clear and follows the project's conventions.

The changes look good overall and appear ready for merging after addressing the minor suggestions above.

opencode session  |  github run