Introduce smartsheet-integration-source header#132
Open
ahmed-ahmed-smartsheet wants to merge 12 commits intosmartsheet:mainlinefrom
Open
Introduce smartsheet-integration-source header#132ahmed-ahmed-smartsheet wants to merge 12 commits intosmartsheet:mainlinefrom
ahmed-ahmed-smartsheet wants to merge 12 commits intosmartsheet:mainlinefrom
Conversation
src/test/java/com/smartsheet/api/internal/AbstractResourcesTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/smartsheet/api/internal/AbstractResourcesTest.java
Outdated
Show resolved
Hide resolved
alexander-penev-smar
changed the title
alexander-penev-smar
previously approved these changes
Aug 13, 2025
… to check the format in SmartsheetIntegrationSourceValidator
…builder which is checked in the validator
…entation of the http headers
velihanzelev-smartsheet
approved these changes
Sep 9, 2025
Contributor
|
This is definitely a breaking change and would require a major version update. Why do we want to force the user to have an Integration ENV var set? That will make the SDK harder to use. @ahmed-ahmed-smartsheet |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
*** DO NOT MERGE ***
Summary
Introduced
smartsheet-integration-sourceheader which is intended to be sent in API requests for integration details.Checklist
./gradlew clean build