feat: include additional report endpoints#158
Open
smcgowan-smartsheet wants to merge 4 commits intosmartsheet:mainlinefrom
Open
feat: include additional report endpoints#158smcgowan-smartsheet wants to merge 4 commits intosmartsheet:mainlinefrom
smcgowan-smartsheet wants to merge 4 commits intosmartsheet:mainlinefrom
Conversation
adding add report scope remove report scope adding wiremock tests for new endpoints
Re-review completed. All previously flagged issues have been successfully resolved.
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
update changelog
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
src/main/java/com/smartsheet/api/internal/ReportResourcesImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/com/smartsheet/api/internal/ReportResourcesImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/com/smartsheet/api/models/enums/ReportAssetType.java
Outdated
Show resolved
Hide resolved
fix style issues
src/main/java/com/smartsheet/api/internal/ReportResourcesImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/com/smartsheet/api/internal/ReportResourcesImpl.java
Outdated
Show resolved
Hide resolved
fix style issues
Re-review completed. All previously flagged issues have been successfully resolved.
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
adding new functions to the report resources:
add report scope
remove report scope
adding wiremock tests for new endpoints
Checklist
./gradlew clean build