Skip to content

Add method types to SDK methods#112

Merged
albertokarakoutev-smar merged 7 commits intomainlinefrom
feature/add-method-types
Dec 11, 2025
Merged

Add method types to SDK methods#112
albertokarakoutev-smar merged 7 commits intomainlinefrom
feature/add-method-types

Conversation

@albertokarakoutev-smar
Copy link
Contributor

@albertokarakoutev-smar albertokarakoutev-smar commented Dec 4, 2025

Pull Request

Description

  • Add generics to all composite types, e.g. IndexResult
  • Add typing to all SDK method signatures
  • Update existing docstrings to reflect typing

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Code refactoring
  • Other (please describe):

Environment Information

  • Smartsheet API Version: 2.0
  • Smartsheet Python SDK Version: 3.5.7
  • Python Version: 3.13

Why These Changes Were Made

To improve usage of the API

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have updated the relevant files in docs-source/ (see Documentation guidelines)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

 * Add generics to all composite types, e.g. IndexResult
 * Add typing to all SDK method signatures
 * Update existing docstrings to reflect typing
@roomote
Copy link
Contributor

roomote bot commented Dec 4, 2025

Rooviewer Clock   See task on Roo Cloud

Re-review completed. No new issues found.

The latest commit is a merge from mainline that updates CHANGELOG with version 3.6.0 release information. No concerns.

Previous reviews

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

 * Add [None] for all necessary typing definitions of methods, in which it was omitted
 * Switch to using `typing.Type[T]` for generic types to support Python <3.9
 * Fix nit
@albertokarakoutev-smar albertokarakoutev-smar merged commit f2a1b7f into mainline Dec 11, 2025
10 checks passed
@albertokarakoutev-smar albertokarakoutev-smar deleted the feature/add-method-types branch December 11, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants