Add method types to SDK methods#112
Merged
albertokarakoutev-smar merged 7 commits intomainlinefrom Dec 11, 2025
Merged
Conversation
* Add generics to all composite types, e.g. IndexResult * Add typing to all SDK method signatures * Update existing docstrings to reflect typing
Contributor
Re-review completed. No new issues found. The latest commit is a merge from mainline that updates CHANGELOG with version 3.6.0 release information. No concerns. Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
ggoranov-smar
requested changes
Dec 8, 2025
* Add [None] for all necessary typing definitions of methods, in which it was omitted * Switch to using `typing.Type[T]` for generic types to support Python <3.9 * Fix nit
ggoranov-smar
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Type of Change
Environment Information
Why These Changes Were Made
To improve usage of the API
Checklist
docs-source/(see Documentation guidelines)