Add support for request compression #968
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhernandez35
reviewed
Dec 9, 2025
client/client-http/src/main/java/software/amazon/smithy/java/client/http/compression/Gzip.java
Show resolved
Hide resolved
.../src/main/java/software/amazon/smithy/java/client/http/compression/CompressionAlgorithm.java
Show resolved
Hide resolved
.../src/main/java/software/amazon/smithy/java/client/http/plugins/RequestCompressionPlugin.java
Show resolved
Hide resolved
sugmanue
reviewed
Dec 11, 2025
.../src/main/java/software/amazon/smithy/java/client/http/compression/CompressionAlgorithm.java
Outdated
Show resolved
Hide resolved
io/src/main/java/software/amazon/smithy/java/io/datastream/GzipInputStream.java
Outdated
Show resolved
Hide resolved
io/src/main/java/software/amazon/smithy/java/io/datastream/GzipInputStream.java
Outdated
Show resolved
Hide resolved
client/client-http/src/main/java/software/amazon/smithy/java/client/http/HttpContext.java
Show resolved
Hide resolved
.../src/main/java/software/amazon/smithy/java/client/http/plugins/RequestCompressionPlugin.java
Outdated
Show resolved
Hide resolved
client/client-http/src/main/java/software/amazon/smithy/java/client/http/compression/Gzip.java
Outdated
Show resolved
Hide resolved
client/client-http/src/main/java/software/amazon/smithy/java/client/http/compression/Gzip.java
Show resolved
Hide resolved
io/src/main/java/software/amazon/smithy/java/io/datastream/GzipInputStream.java
Outdated
Show resolved
Hide resolved
Contributor
|
More in general, can you please use consistently |
sugmanue
reviewed
Dec 14, 2025
| import java.io.InputStream; | ||
| import java.util.zip.GZIPOutputStream; | ||
|
|
||
| final class GzipCompressingInputStream extends InputStream { |
Contributor
There was a problem hiding this comment.
This implementation underneath still reads the whole input stream into memory to do the compression.
Comment on lines
33
to
34
| if (available <= 0) | ||
| return -1; |
Comment on lines
45
to
47
| try (GZIPOutputStream gzip = new GZIPOutputStream(buffer)) { | ||
| source.transferTo(gzip); | ||
| } |
Contributor
There was a problem hiding this comment.
This reads all the contents from source and transfers them to the gzip output stream.
sugmanue
reviewed
Dec 15, 2025
| CompressionAlgorithm.supportedAlgorithms(); | ||
|
|
||
| @Override | ||
| public <RequestT> RequestT modifyBeforeTransmit(RequestHook<?, ?, RequestT> hook) { |
Contributor
There was a problem hiding this comment.
I think we should use here modifyBeforeRetryLoop instead. We want to compress only once instead of for each retry.
Also, we need to make sure that compression and streaming plays well with retries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added a new plugin to process request compression if
@requestCompressiontrait is applied. With this feature, those protocol tests regarding content-encoding can pass now.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.