Add http-1x examples for server SDK usage #4377
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcoh
reviewed
Nov 3, 2025
examples/upgrade-http1x.md
Outdated
Comment on lines
222
to
224
| ## Client-Side Changes | ||
|
|
||
| ### HTTP Client Connector Setup |
Collaborator
There was a problem hiding this comment.
need to call out that client/server http versions are totally decoupled.
Contributor
Author
There was a problem hiding this comment.
I need to check with the SDK team on this section. For the time being I am removing it.
examples/upgrade-http1x.md
Outdated
| ### 3. Request Handling | ||
|
|
||
| Most request handling code remains the same thanks to smithy-rs abstractions: | ||
|
|
Collaborator
There was a problem hiding this comment.
probably no need to bother calling this out.
| @@ -0,0 +1,54 @@ | |||
| // Code generated by software.amazon.smithy.rust.codegen.smithy-rs. DO NOT EDIT. | |||
| #[allow(clippy::unnecessary_wraps)] | |||
| pub async fn de_check_health_http_request<B>( | |||
Collaborator
There was a problem hiding this comment.
I don't think you meant to check in this entire directory
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
drganjoo
force-pushed
the
fahadzub/http-1.x-examples
branch
from
21d6619 to
13d6532
Compare
drganjoo
force-pushed
the
fahadzub/http-1.x-examples
branch
from
13d6532 to
448b981
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates examples to demonstrate server SDK usage with both http@0.2.x
and http@1.x, supporting the http-1x migration effort.
Changes
New Directories
legacy/: Complete set of examples using http@0.2.x/hyper@0.14 with
aws-smithy-legacy-http-server. These examples preserve the original behavior
for users not yet ready to migrate.
pokemon-service-server-skd-patch/: Compatibility layer and patches for
bridging http@0 and http@1 types in server SDK.
Updated Examples
Modified existing examples to use http@1.x/hyper@1.x:
Key Updates
Testing
Examples can be run with both HTTP versions to verify compatibility.
Relates to #3362