Conversation
…and for fingerprint and profile plot and for heatmap
…ach antibody, adaptations for snakemake workflow catalog, more plot descriptions for report, cleanup configs, README and ToDo's
dlaehnemann
left a comment
dlaehnemann
left a comment
There was a problem hiding this comment.
Great work, thanks a bunch!
I did not manage to go through everything, yet, but wanted to at least release this batch of comments. I should be approximately half way through...
dlaehnemann
left a comment
dlaehnemann
left a comment
There was a problem hiding this comment.
Once again, great work. And some more suggestions on the second half of this pull request. This is looking really good. We just have to clean up a bit more and we'll finally have that exemplary reimplementation of a nextflow workflow! 🎉
|
Thank you very much for the review and the many great suggestions! |
dlaehnemann
left a comment
dlaehnemann
left a comment
There was a problem hiding this comment.
Thanks again for this major effort. And here finally comes my review. This all looks very good, and any remaining suggestions are either just formatting to improve readability or wording changes to make the report even clearer. Just two actual questions, I think. So we're almost done!
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
Co-authored-by: David Laehnemann <david.laehnemann@hhu.de>
|
Thank you very much for reviewing the PR and the great and helpful suggestions! |
2 participants
Description for plots used in report added, changes on deseq2 for comparisons of samples across the groups from each antibody, adaptations for snakemake workflow catalog, cleanup configs, README and ToDo's