Adding support for private_key_file_pwd field from connections.toml#2739
Open
costrouc wants to merge 5 commits intosnowflakedb:mainfrom
Open
Adding support for private_key_file_pwd field from connections.toml#2739costrouc wants to merge 5 commits intosnowflakedb:mainfrom
costrouc wants to merge 5 commits intosnowflakedb:mainfrom
Conversation
Closes snowflakedb#2738 Prior to this PR the snowflake cli only supported PRIVATE_KEY_PASSPHRASE. The snowflake python connector which this library uses supports private_key_file_pwd. This PR: - adds the field `private_key_file_pwd` to the config - uses the `private_key_file_pwd` and then falls back to using the environment variable PRIVATE_KEY_PASSPHRASE for compatibility - adds the private_key_file_pwd to masked sensitive parameters
…Y_PASSPHRASE is prefered
costrouc
force-pushed
the
feat-use-private-key-file-pwd
branch
from
f870b2e to
f90c5af
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2738
Pre-review checklist
Changes description
Prior to this PR the snowflake cli only supported
PRIVATE_KEY_PASSPHRASE. The snowflake python connector which this library uses supports private_key_file_pwd.
This PR:
private_key_file_pwdto the configprivate_key_file_pwdfor compatibilityprivate_key_file_pwdto masked sensitive parameters