Open
Conversation
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+111
to
+114
| try: | ||
| importlib.reload(sys.modules[module]) | ||
| except: | ||
| pass |
Contributor
There was a problem hiding this comment.
Bare except: clause catches all exceptions including system-level exceptions like KeyboardInterrupt and SystemExit. This can prevent proper test shutdown and make debugging difficult.
except Exception:
passShould use except Exception: instead to only catch application-level exceptions.
Suggested change
| try: | |
| importlib.reload(sys.modules[module]) | |
| except: | |
| pass | |
| try: | |
| importlib.reload(sys.modules[module]) | |
| except Exception: | |
| pass |
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
sfc-gh-mraba
previously approved these changes
Feb 17, 2026
Comment on lines
+112
to
+113
| from snowflake.connector.errors import BadRequest | ||
| from snowflake.connector.vendored.requests.exceptions import HTTPError |
Contributor
There was a problem hiding this comment.
How about hiding all vendored errors behind connector ones.
This would make imports nicer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
Mostly avoid top level imports that won't be available in universal driver.