Use uv and hatch for building and dependency management#4054
Open
dylwil3 wants to merge 3 commits intosnowflakedb:mainfrom
Open
Use uv and hatch for building and dependency management#4054dylwil3 wants to merge 3 commits intosnowflakedb:mainfrom
uv and hatch for building and dependency management#4054dylwil3 wants to merge 3 commits intosnowflakedb:mainfrom
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
recheck |
uv and hatch for building and dependncy managementuv and hatch for building and dependency management
Contributor
|
Thanks for the PR! This looks like an interesting direction, and would be a very helpful contribution. I've got a few comments/questions:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apologies in advance for the "speculative" pull request - I know that is not a maintainer's favorite thing to come across. I'm just curious if you would be interested in migrating the build setup to something a bit more modern.
This removes the
setup.py"dynamic" setup in favor of putting everything inpyproject.toml. That means less code to maintain, and it's easier to build and install.If this is of interest I can spend more time seeing if other parts of the code need to be fixed to support this change (e.g.
tox.ini, CI, etc.). I can also make sure all the tests pass - so far I only checked the ones that don't require credentials.Let me know, and if not then no worries!