Skip to content

Comments

NO-SNOW: Fix daily test failures caused by alias flattening#4087

Merged
sfc-gh-joshi merged 1 commit intomainfrom
joshi/alias-daily-fixes
Feb 23, 2026
Merged

NO-SNOW: Fix daily test failures caused by alias flattening#4087
sfc-gh-joshi merged 1 commit intomainfrom
joshi/alias-daily-fixes

Conversation

@sfc-gh-joshi
Copy link
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-NNNNNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines
  3. Please describe how your code solves the related issue.

Fixes some test failures caused by #4078.

  • tests/integ/test_multithreading.py::test_large_query_breakdown_with_cte: The new alias removal reduced the complexity of the generated query; with trial and error in Cursor, the new bounds in this test trigger query breakdown again.
  • tests/integ/scala/test_snowflake_plan_suite.py::test_plan_height: Since some of the new alias optimization code exists outside of the SQL simplifier, the depth of generated joins has been reduced. The depth did not decrease when the SQL simplifier is enabled due to the presence of intermediate SelectStatement objects.
  • tests/integ/compiler/test_query_generator.py::test_select_alias_identity: The specific optimization here relies on the SQL simplifier being enabled, so the generated query is different if it is not.

@sfc-gh-joshi sfc-gh-joshi added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Feb 23, 2026
@sfc-gh-joshi sfc-gh-joshi merged commit b620fc0 into main Feb 23, 2026
35 of 36 checks passed
@sfc-gh-joshi sfc-gh-joshi deleted the joshi/alias-daily-fixes branch February 23, 2026 21:02
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants