Skip to content

fix: improve CLI download error handling [IDE-1690] #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
rrama wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

fix: improve CLI download error handling [IDE-1690] #353

rrama wants to merge 4 commits into from

Conversation

@rrama
Copy link
Contributor

@rrama rrama commented Jan 15, 2026

Description

  • Add HTTP status code validation in FileDownloadResponseHandler (only accept 2xx responses, log response body for debugging).
  • Include download URL and status code in error messages.
  • Gracefully handle download failures in SnykStartup, but allow LS startup with existing binary if available.
  • Validate CLI binary exists before starting language server, with helpful error message suggesting to check Error Log when "Manage Binaries Automatically" is enabled.

Checklist

  • Read and understood the Code of Conduct and Contributing Guidelines.
  • Tests added and all succeed
  • Linted
  • CHANGELOG.md updated
  • Nah, too small a bug fix.
  • README.md updated, if user-facing
  • N/A

Screenshots / GIFs

Screenshot 2026-01-15 at 15 33 14 ^ I changed the log levels slightly, but close enough to the end result.

@rrama
fix: improve CLI download error handling
40f3f6f 
- Add HTTP status code validation in FileDownloadResponseHandler (only accept 2xx responses, log response body for debugging).
- Include download URL and status code in error messages.
- Gracefully handle download failures in SnykStartup, but allow LS startup with existing binary if available.
- Validate CLI binary exists before starting language server, with helpful error message suggesting to check Error Log when "Manage Binaries Automatically" is enabled.
@snyk-io
Copy link

snyk-io bot commented Jan 15, 2026 •
edited
Loading

✅ Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rrama