Support customisation in Objective-C #27
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soberman
reviewed
Mar 24, 2018
| ars_createdFrameForBackgroundView(loader.backgroundView, title:loader.title, onView: targetView) | ||
| } else { | ||
| ars_createdFrameForBackgroundView(loader.backgroundView, onView: nil) | ||
| ars_createdFrameForBackgroundView(loader.backgroundView, title:loader.title, onView: nil) |
Owner
There was a problem hiding this comment.
Please keep the formatting the same way it was before.
Source/ARSLineProgress.swift
Outdated
| */ | ||
| public static func showFail() { | ||
| if !statusShown { ARSStatus.show(.fail) } | ||
| if !statusShown { ARSStatus.show(.success, title: "") } |
Owner
There was a problem hiding this comment.
Why showFail method is using .success parameter inside of it?
Source/ARSLineProgress.swift
Outdated
| } | ||
|
|
||
| public static func showFail(title: NSString) { | ||
| if !statusShown { ARSStatus.show(.success, title: title) } |
Owner
There was a problem hiding this comment.
The same one here: fail method has success parameter? Why?
Source/ARSLineProgressHelpers.swift
Outdated
|
|
||
| @discardableResult func ars_createdFrameForBackgroundView(_ backgroundView: UIView, onView view: UIView?) -> Bool { | ||
| func sizeForTitle(_ title : NSString?) -> CGSize{ | ||
| if title != nil{ |
Owner
There was a problem hiding this comment.
- Space before curly brace.
- For comprehension it is better to use
guards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow to access ARSLineProgressConfiguration from Objective-c