chore: allow new versions of duckdb #2527
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The duckdb version was pinned to below 1.1.0 because the dataframe behavior changed then. This PR restores the old behavior of scanning all registered dataframes, but because this option was only added in DuckDB 1.1.0, this version now becomes the minimum.
This PR also standardizes the duckdb configuration used in the in-memory and path-based connections and, because
:default:in-memory singleton cannot accept configuration, switches from:default:to:memory:. The in-memory duckdb instances are so lightweight though that it won't make any measurable difference.I've added
<2.0as the dependency ceiling, but DuckDB treats its twice-a-yearly minor releases as major, so if you'd like to be conservative, the ceiling should be<1.5, which will be released in February.custom_user_agentis a DuckDB property. It was added in DuckDB 1.0, so no additional constraints are needed.