Skip to content

Conversation

@hugtalbot
Copy link
Contributor

Apply template method design pattern to BaseMass and its API:

  • addMDx
  • addMToMatrix
  • buildMassMatrix
  • accFromF
  • addGravityToV
  • getKineticEnergy
  • getPotentialEnergy
  • getMomentum
  • initGnuplot
  • exportGnuplot
  • getElementMass
  • isDiagonal

I created this PR in two parts since I doubt we actually need these functions to be concerned by the refactoring:

  • initGnuplot
  • exportGnuplot
  • getElementMass
  • isDiagonal

[ci-depends-on https://github.com/sofa-framework/BeamAdapter/pull/188]
[with-all-tests]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@hugtalbot hugtalbot added pr: breaking Change possibly inducing a compilation error pr: status to review To notify reviewers to review this pull-request refactoring Refactor code labels May 12, 2025
@sofabot
Copy link
Collaborator

sofabot commented May 12, 2025

[ci-depends-on] detected during build #1.

To unlock the merge button, you must

@hugtalbot
Copy link
Contributor Author

[ci-build] [with-all-tests]

@sofa-framework sofa-framework deleted a comment from sofabot May 13, 2025
@sofabot
Copy link
Collaborator

sofabot commented May 13, 2025

[ci-depends-on] detected during build #3.

To unlock the merge button, you must

@sofabot
Copy link
Collaborator

sofabot commented May 13, 2025

[ci-depends-on] detected during build #4.

To unlock the merge button, you must

@sofabot
Copy link
Collaborator

sofabot commented May 14, 2025

[ci-depends-on] detected during build #5.

To unlock the merge button, you must

@sofabot
Copy link
Collaborator

sofabot commented May 15, 2025

[ci-depends-on] detected during build #6.

To unlock the merge button, you must

@hugtalbot hugtalbot added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: breaking Change possibly inducing a compilation error pr: status wip Development in the pull-request is still in progress refactoring Refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants