[Sofa.Core] Merge BaseContext and Context #5608
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to the issue: #5556
The PR is based on #5566, please merge it to make the difference clear.
At this step, it is unclear to me how to move forward.
The Context seems to be a not very well defined concept as it shares properties with the scene graph structure.
The fact it stores data field like dt, t, gravity... and it is also a BaseObject makes me think that possible path could be to simply add make it to the factory and have the context as one of the a node component. The get<> should probably be moved out of the context unless we want a context to explore the local children and objects or not.
This will breaks everything that makes the assumption that dt, node are node attributes.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if