Skip to content

Fix null provider config #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jvliwanag wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix null provider config #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/main/scala/Docker.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,9 @@ object Docker {
)
val http0 = new Http().configure { builder =>
val config = builder.build()
val updatedProvider = config.getAsyncHttpProviderConfig match {
val currentProvider = Option(config.getAsyncHttpProviderConfig)
Copy link
Owner

@softprops softprops Feb 27, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm actually surprised this can be null. This modifies the default config provided by dispatch. It's it possible there is a bug upstream?

.getOrElse(new NettyAsyncHttpProviderConfig())
val updatedProvider = currentProvider match {
case netty: NettyAsyncHttpProviderConfig =>
netty.addProperty(
NettyAsyncHttpProviderConfig.SOCKET_CHANNEL_FACTORY,
Expand Down