Skip to content

fix(solace-message-client): Don't break complete message parsing if s…#96

Open
GreenRover wants to merge 1 commit intosolacecommunity:masterfrom
GreenRover:hotfix/breakingheader
Open

fix(solace-message-client): Don't break complete message parsing if s…#96
GreenRover wants to merge 1 commit intosolacecommunity:masterfrom
GreenRover:hotfix/breakingheader

Conversation

@GreenRover
Copy link
Collaborator

…ingle header is not JavaScript compatible

JavaScript type number is only precise up to 48bit / 53bit (depends on source of information). If a java long with 64 bit is received, this header field is not parse able in js. Therefore, the solclientjs lib will throw an error.

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added
  • Docs have been added or updated

PR Type

What kind of change does this PR introduce?

  • Fix
  • Feature
  • Documentation
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Performance (changes that improve performance)
  • Test (adding missing tests, refactoring tests; no production code change)
  • Chore (other changes like formatting, updating the license, removal of deprecations, etc)
  • Deps (changes related to updating dependencies)
  • CI (changes to our CI configuration files and scripts)
  • Revert (revert of a previous commit)
  • Release (publish a new release)
  • Other... Please describe:

Issue

Issue Number: #

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

…ingle header is not JavaScript compatible

JavaScript type number is only precise up to 48bit / 53bit (depends on source of information). If a java long with 64 bit is received, this header field is not parse able in js. Therefore, the solclientjs lib will throw an error.
@GreenRover GreenRover requested a review from danielwiehl January 5, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants