Add PoC python script simulating the tower bft lockout algorithm#28
Open
jarry-xiao wants to merge 1 commit intosolana-foundation:mainfrom
Open
Add PoC python script simulating the tower bft lockout algorithm#28jarry-xiao wants to merge 1 commit intosolana-foundation:mainfrom
jarry-xiao wants to merge 1 commit intosolana-foundation:mainfrom
Conversation
ripatel-fd
reviewed
May 30, 2023
Collaborator
ripatel-fd
left a comment
ripatel-fd
left a comment
There was a problem hiding this comment.
Would you mind moving this to solana_specs/consensus/tower_bft.py?
Otherwise, looks good to go.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
0xEdgar
reviewed
Aug 3, 2023
| entry.expired = True # Mark the entry to be removed | ||
| expired_slots.append(i) | ||
|
|
||
| # Remove all expired towers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wrote a script that implements the algorithm described on the Solana docs page: https://docs.solana.com/implemented-proposals/tower-bft#algorithm
It at least makes the exact logic codified in a more digestible way.
The state updates identically to the outputs specified in this document. I'm not an expert here, so my code might not be 100% correct. Should be enough to get started though.