-
Notifications
You must be signed in to change notification settings - Fork 5
Gate JEI mixin behind mod presence check to prevent crashes without JEI #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
solidDoWant
merged 6 commits into
fix/jei-plugin-loading-1
from
copilot/sub-pr-13-again
Jan 20, 2026
Merged
Gate JEI mixin behind mod presence check to prevent crashes without JEI #15
solidDoWant
merged 6 commits into
fix/jei-plugin-loading-1
from
copilot/sub-pr-13-again
Jan 20, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: solidDoWant <16456946+solidDoWant@users.noreply.github.com>
Co-authored-by: solidDoWant <16456946+solidDoWant@users.noreply.github.com>
Co-authored-by: solidDoWant <16456946+solidDoWant@users.noreply.github.com>
Co-authored-by: solidDoWant <16456946+solidDoWant@users.noreply.github.com>
Co-authored-by: solidDoWant <16456946+solidDoWant@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Fix fluid encoder JEI support based on review feedback
Gate JEI mixin behind mod presence check to prevent crashes without JEI
Jan 20, 2026
solidDoWant
approved these changes
Jan 20, 2026
solidDoWant
added a commit
that referenced
this pull request
Jan 20, 2026
* try mixin approach Signed-off-by: solidDoWant <fred.heinecke@yahoo.com> * remove d ebug code Signed-off-by: solidDoWant <fred.heinecke@yahoo.com> * Fix hasInputFluids check to prevent shaped recipe compression (#14) * Initial plan * Fix hasInputFluids and hasOutputFluids calculation Co-authored-by: solidDoWant <16456946+solidDoWant@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: solidDoWant <16456946+solidDoWant@users.noreply.github.com> * rm dead code Signed-off-by: solidDoWant <fred.heinecke@yahoo.com> * rm old import, warning Signed-off-by: solidDoWant <fred.heinecke@yahoo.com> * address PR comments Signed-off-by: solidDoWant <fred.heinecke@yahoo.com> * Gate JEI mixin behind mod presence check to prevent crashes without JEI (#15) * Initial plan * Add IMixinConfigPlugin to gate JEI mixin behind mod presence check Co-authored-by: solidDoWant <16456946+solidDoWant@users.noreply.github.com> * Use startsWith for more precise JEI mixin package detection Co-authored-by: solidDoWant <16456946+solidDoWant@users.noreply.github.com> * Make JEI package detection more robust using mixinPackage parameter Co-authored-by: solidDoWant <16456946+solidDoWant@users.noreply.github.com> * Extract JEI constants and fix formatting Co-authored-by: solidDoWant <16456946+solidDoWant@users.noreply.github.com> * Add documentation for JEI package convention Co-authored-by: solidDoWant <16456946+solidDoWant@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: solidDoWant <16456946+solidDoWant@users.noreply.github.com> * fix import Signed-off-by: solidDoWant <fred.heinecke@yahoo.com> * Statically init GT_ENERGISTICS_HANDLER Signed-off-by: solidDoWant <fred.heinecke@yahoo.com> --------- Signed-off-by: solidDoWant <fred.heinecke@yahoo.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: solidDoWant <16456946+solidDoWant@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
jei.RecipeRegistryMixinwas unconditionally loaded in the client mixin set, causing crashes when JEI is not installed (JEI is declared as an optional dependency viaafter:jei).Changes
GregTechEnergisticsMixinPlugin: ImplementsIMixinConfigPluginto conditionally load mixins based onLoader.isModLoaded("jei")mixins.gregtechenergistics.json.jeisubpackage are gated; all other mixins load unconditionallyThe plugin derives the JEI package dynamically from the
mixinPackageparameter, making it resilient to package refactoring.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.