Verify fluid handling in crafting recipes #16
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copilot
AI
changed the title
[WIP] Fix fluid encoder JEI support based on feedback
Verify fluid handling in crafting recipes
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verified that vanilla crafting recipes (
VanillaRecipeCategoryUid.CRAFTING) cannot contain fluids, as they are 3x3 crafting table recipes that only accept ItemStacks. Fluids require containers (buckets) or machine/processing recipes.Analysis
The reviewer's concern about shaped recipe reordering when fluids use sequential filling doesn't apply because:
VanillaRecipeCategoryUid.CRAFTINGrecipes never have fluidsisCraftingRecipeis true,recipeLayout.getFluidStacks()returns null/emptyperformTransferWithSlots()exits early (line 77-78) without populating fluid arrayspreserveSlotsparameter has no effect since there are no fluids to transferThe current implementation at line 63 (
preserveSlots=falsefor fluids) is correct. Changing it to mirror item behavior (preserveSlots=isCraftingRecipe) would be functionally equivalent but unnecessary since crafting recipes have no fluids to preserve slots for.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.