feat: Allow to overwrite track_state_change? #6380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:solidus_core
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6380 +/- ##
=======================================
Coverage 89.45% 89.46%
=======================================
Files 974 975 +1
Lines 20322 20335 +13
=======================================
+ Hits 18179 18192 +13
Misses 2143 2143 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mamhoff
reviewed
Nov 21, 2025
Some stores might have their own logi of tracking state changes. Let's give them a way to disable the built in state change tracking by overwriting the `track_state_change?` per model instance. It defaults to the current behavior of tracking a state change if there is `saved_change_to_state?` from `ActiveRecord::Dirty`.
tvdeyen
force-pushed
the
state-change-tracking-toggle
branch
from
6663151 to
08ed515
Compare
mamhoff
approved these changes
Nov 21, 2025
adammathys
approved these changes
Nov 25, 2025
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some stores might have their own logi of tracking state changes. Let's give them a way to disable the built in state change tracking by overwriting the
track_state_change?per model instance. It defaults to the current behavior of tracking a state change if there issaved_change_to_state?fromActiveRecord::Dirty.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: