Check whether the logfile is a regular file. Fixed incomplete privilege drop.#105
Open
m0n73 wants to merge 2 commits intosolusipse:masterfrom
Open
Check whether the logfile is a regular file. Fixed incomplete privilege drop.#105m0n73 wants to merge 2 commits intosolusipse:masterfrom
m0n73 wants to merge 2 commits intosolusipse:masterfrom
Conversation
…ivelege dropping code and fixed error checking.
Author
|
Adding another commit to this pull request, which fixes incomplete privilege drop in |
m0n73
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the requested log file (
-loption) isn't a regular file,fopenwill fail to open it, subsequently passing aNULLpointer intofclosewhich causes a segfault. This patch adds an appropriate file type check and shifts the logic around, so that we only create a new log file if it doesn't already exist.