-
Notifications
You must be signed in to change notification settings - Fork 1
246 devops fully migrate to pyprojecttoml #264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
enrico-lattuada
merged 42 commits into
develop
from
246-devops-fully-migrate-to-pyprojecttoml
Nov 13, 2025
Merged
246 devops fully migrate to pyprojecttoml #264
enrico-lattuada
merged 42 commits into
develop
from
246-devops-fully-migrate-to-pyprojecttoml
Nov 13, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
krauthex
previously approved these changes
Jul 2, 2025
Collaborator
krauthex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much @enrico-lattuada for your efforts! The changes look good to me, at least as far as I understand CMake ;-) Making pybind11 an install dependency definitely is the much cleaner approach.
The base branch was changed.
Collaborator
|
Except this minor changes it's clean! |
eXpensia
reviewed
Nov 13, 2025
eXpensia
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
difficulty: hard
Complex tasks
priority: high
Important improvements or optimizations
type: build
Tasks related to packaging, installation scripts, and setup
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
setup.pypyproject.tomlto include a CMake backend (e.g.,scikit-build-core)Motivation and context
The
setup.pyframework is outdated, andpyproject.toml(with modern tools) can do the same job with less maintenance effort.Resolves #246
How has this been tested?
Change log
Checklist:
docs/source/credits.rst) in the pull request source branch.