Conversation
sonesuke
force-pushed
the
fix/ci-chrome-path
branch
from
e47716d to
647d355
Compare
- Remove unnecessary Chrome setup steps (ubuntu-latest has Chrome pre-installed) - Remove CHROME_BIN environment variable setup - Remove SKIP_BROWSER_TESTS (browser tests should run) - Revert browser.rs --no-sandbox changes This restores the CI configuration that was working in commit 7ba3223 (v0.1.0). Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Add Chrome setup step that verifies Chrome/Chromium existence - Create config file with browser_path pointing to pre-installed Chrome - Increase Chrome startup timeout from 10s to 30s for slower CI environments - Update troubleshooting message to suggest using config command Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix CI Chrome path issue
Chrome is installed by
browser-actions/setup-chromeat/opt/hostedtoolcache/setup-chrome/chromium/*/x64/chrome, but the code was looking for/usr/bin/google-chrome.This PR sets
CHROME_BINto the correct path so tests can find Chrome in CI.