Skip to content

feat: ijekavica demo#200

Open
noomorph wants to merge 2 commits intomasterfrom
feat/ijekavica-indexing
Open

feat: ijekavica demo#200
noomorph wants to merge 2 commits intomasterfrom
feat/ijekavica-indexing

Conversation

@noomorph
Copy link
Collaborator

@noomorph noomorph commented Feb 13, 2022

Proof of concept for Ekavian/Ijekavian search in Serbian.

Code

Ekavica:

lowerCaseText.replace(/(е̖|е̱|е̩)/g, 'е')

Ijekavica:

 lowerCaseText
     .replace(/ле̖̩/g, 'ље')
     .replace(/не̖/g, 'ње')
     .replace(/е̖/g, 'је')
     .replace(/е̱/g, 'ије')
     .replace(/е̩/g, 'и')

Sheets

image

App

photo_2022-02-13 12 47 45

WDYT, @sonic16x , @ru-danko ?
Any ideas on how to rewrite a couple of hardcoded places?

@noomorph noomorph requested a review from sonic16x February 13, 2022 10:39
{
spreadsheetId: '1N79e_yVHDo-d026HljueuKJlAAdeELAiPzdFzdBuKbY',
sheetId: '1987833874',
spreadsheetId: '11TEUKt52TXnLbCvUWzSFK7zzDOzqsyHKw7dt2iZ0dD8',
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For demo purpose.

}

this.splittedMap[lang].set(id, splittedField);
if (lang === 'sr') {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blatant hardcode... but I need to make sure we remove those нагове̖штавање, нагове̖штај from the visual results.

columns.forEach((column: string[]) => {
const fieldName = getColumnName(column);

if (fieldName === 'sr') {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again some blatant hardcode... but I need to make sure we remove those нагове̖штавање, нагове̖штај from the visual results.

"scripthost",
"es2015.collection"
"es2015",
"es2019.array"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing, do we have autopolyfilling for latest browsers > 0.5%? Should I worry about using Array.prototype.flatMap, @sonic16x ?

@coveralls
Copy link

coveralls commented Feb 13, 2022

Pull Request Test Coverage Report for Build 1887839461

  • 0 of 42 (0.0%) changed or added relevant lines in 5 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.06%) to 29.522%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/utils/filterDiacritics/index.ts 0 1 0.0%
src/services/generateDictionary.ts 0 4 0.0%
src/utils/filterDiacritics/filterDiacritics.ts 0 4 0.0%
src/components/Pages/Viewer/Viewer.tsx 0 11 0.0%
src/services/dictionary.ts 0 22 0.0%
Files with Coverage Reduction New Missed Lines %
src/components/Loader/Loader.tsx 2 0%
src/services/dictionary.ts 2 0%
Totals Coverage Status
Change from base Build 1818126141: -0.06%
Covered Lines: 1318
Relevant Lines: 5459

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants