Enhancement/examples #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on MongoStore This seemed to occur in applications where multiple event loops might be created but all access the same schema or model classes e.g. in pytests.
… in RedisStore RedisModel's are originally associated with a given database at registration. During execution, this database is accessed at RedisModel.db(). When the same model is registered in different databases, an error would be thrown. This was resolved by setting the database to the current database before every CRUD operation.
Tinitto
force-pushed
the
enhancement/examples
branch
from
0efd1a5 to
8ab6be7
Compare
Tinitto
force-pushed
the
enhancement/examples
branch
from
8ab6be7 to
759b50b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
To show how the library can be used in a real application.
What was done:
Added
Changed
MongoStore.find(),MongoStore.update(),MongoStore.delete()with their first optionalkey-word argument
query.limitparameter of theMongoStore.find()to be by default 0.Beanie-odm-specific arguments passed toMongoStore.insert(),MongoStore.find(),MongoStore.update(),MongoStore.delete().Fixed
MongoStore.insert(),MongoStore.find(),MongoStore.update(),MongoStore.delete()are called especially during tests that create different event loops.
SQLStore.delete()to return any nested items that were deleted.RedisStore.insert(),RedisStore.find(),RedisStore.update(),RedisStore.delete()are called especially during tests that create different event loops.