Skip to content

Conversation

@jviotti
Copy link
Member

@jviotti jviotti commented Jan 8, 2026

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@augmentcode
Copy link

augmentcode bot commented Jan 8, 2026

🤖 Augment PR Summary

Summary: Updates the vendored sourcemeta/core dependency to 376f397db98e72be48d8401e2fbf2ee96f033966.
Why: Pulls in upstream pointer/lifecycle fixes and WeakPointer-oriented APIs used by schema tooling.
Changes:

  • Adds non-const jsonpointer::get(JSON&, WeakPointer) to allow in-place mutation via weak pointers.
  • Migrates SchemaFrame and related callbacks/maps from Pointer to WeakPointer to reduce allocations/copies.
  • Updates schema bundling/transformer/editor utilities to convert to strong pointers only when needed (e.g., errors, deferred edits).
  • Adjusts formatting to defer object reordering until after frame teardown to avoid invalidating frame views.
  • Adds SchemaFrame::has_references_through(..., tail) to check references through a specific keyword token.
  • Refactors multiple AlterSchema rules to use static keyword strings and new tail-token reference checks.
Notes: This is primarily an upstream sync; most diffs are mechanical API updates around pointer types and reference tracking.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@jviotti jviotti merged commit 0c23409 into main Jan 8, 2026
13 checks passed
@jviotti jviotti deleted the core-weak branch January 8, 2026 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants