-
Notifications
You must be signed in to change notification settings - Fork 12
NASA Challenge_[@damianphim]_[Update Documentation] (closes #34) #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NASA Challenge_[@damianphim]_[Update Documentation] (closes #34) #37
Conversation
Not just you, I spent a day and haven't been able to see Mars rover on a simulator yet :/ I see this PR is updating |
Sounds like you made more progress than me on my first day, don't give up!
I believe the ROS 2 documentation also uses .rst files, which could be it. |
1b8bb56 to
1b8a062
Compare
|
EDIT: I've applied this change to the PR. @damianphim Can you please remove the file This looks like a temporary (vim?) file that was introduced by mistake. |
|
EDIT: I've applied this change to the PR. @damianphim Can you please also squash the two commits (since the second just fixes things about the first commit), and rephrase the commit message to be:
Another suggestion, is the order of sections in the first time build tutorial ideal? Should connecting to a container come before generating tests? (it's a bit strange to me that it comes between the tests and IKOS). |
… time build instructions (space-ros#34). This commit creates documentation to build the MoveIt2 image, and to build and run the Canadaarm and Mars Curiosity demos. It also updates the First-Time Build Tutorial with build instructions, and steps to run commands in a Space ROS image, to build the tests, and to run generate the reports from IKOS.
1b8a062 to
e987f91
Compare
|
@ivanperez-keera, I've got journal and SBIR reviews occupying my next few evenings but I'll get to this before the weekend. |
asimonov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have looked through the changes and they look correct!
Closes #34
Demo and First-Time Building Overhaul
Previously, there was no documentation for any of the demos and the Space ROS documentation was outdated, so it took me like 3 days (embarrassing I know) to just build and get the demos running without any errors.
This PR updates the First-Time Building Space ROS page in the documentation (Tutorials -> First-Time Building Space ROS) to the latest method. In addition, it adds documentation for building and running MoveIt2, the Canadarm Demo, and the Curiosity Mars Rover demo.
I'm hoping this PR helps any future contributors not run into the same wall that I did!