feat!: reorganize submissions-finding-quorum storage with SubmissionsV1 #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, submissions storage is keyed from the data hash to the accounts, rather than keyed from an account to data hash. This design choice makes it possible for submitters to disagree with themselves, and input an unbounded number of unique submissions for the same batch id. The solution for this is to change the map from being.. ``` BatchId -> DataHash -> QuorumScope -> [AccountId] ``` to... ``` BatchId -> QuorumScope -> AccountId -> DataHash ``` This change adds a new piece of storage SubmissionsV1 to reflect that second mapping, and switches the pallet-indexing logic over to using it. No data migration is provided, since submissions are fairly disposable in practice. A future PR will handle clearing out the old submissions (and even pruning the new submissions).
Recent changes have been made that switch pallet-indexing to using a newer form of submissions storage to find quorum. This change re-benchmarks the weights (which didn't really change much).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Currently, submissions storage is keyed from the data hash to the accounts, rather than keyed from an account to data hash. This design choice makes it possible for submitters to disagree with themselves, and input an unbounded number of unique submissions for the same batch id.
The solution for this is to change the map from being..
to...
This change adds a new piece of storage SubmissionsV1 to reflect that second mapping, and switches the pallet-indexing logic over to using it. No data migration is provided, since submissions are fairly disposable in practice. A future PR will handle clearing out the old submissions (and even pruning the new submissions).
What changes are included in this PR?
Are these changes tested?
Yes.