fix: separate submit data weights by commitment scheme #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submissions to hyperkzg-only tables are significantly faster than others. So, it would be nice to allow greater throughput for submissions to hyperkzg-only tables instead of limiting them by the dynamic dory bottleneck. This change updates the benchmarks to calculate two separate weights for the different commitment schemes.
We now have benchmarks for data submission to hyperkzg and dynamic dory tables calculated separately. This change actually performs the benchmark to get these new weights, and applies them for the submit data extrinsics.
We now have a significantly lower weight for hyperkzg-only tables than any other configuration. This change updates the runtime weight constants to be based off this lower weight to make sure costs for these inserts are still the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Submissions to hyperkzg-only tables are significantly faster than others. So, it would be nice to allow greater throughput for submissions to hyperkzg-only tables instead of limiting them by the dynamic dory bottleneck.
What changes are included in this PR?
Are these changes tested?
These changes do not affect existing functionality, which should be verified by existing tests.