feat: rearrange submissions storage map and apply more submission limits #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to incoroporate the polkadot migrations pallet into our runtime if we want to be able to perform multi-block storage migrations. This is especially relevant as we are entering a more stable development phase, and all breaking storage changes in the future will need to be handled via migrations.
A previous commit added an additional pallet (pallet-migrations) to the runtime. In order to reflect this change in the versioning of the runtime, the spec_version should be updated.
There is an edge case that wasn't accounted for in the current pallet-indexing implementation. While submissions were rejected when an account submitted multiple times for the same batch with the same data, they were not rejected if they submitted multiple times for the same batch with different data. Furthermore, while there was a submission count limit for a single data hash, there was no limit being applied across all submissions for a given batch id. This leads to a potential attack vector, a submitter could submit disagreeing data and increase the storage size for a single batch id as much as they wanted. This makes a couple changes to handle submission structures and limits better. Firstly, the submissions storage map has been rearranged to enforce some of the desired limitations with typing alone. While before the structure was.. ``` batch_id -> data_hash -> quorum_scope -> submitter_list ``` Now, it is ``` batch_id -> quorum_scope -> submitter -> data_hash ``` This new mapping makes it so there is only one data hash per submitter per quorum scope per batch. Furthermore, the extrinsics have been changed so that the MAX_SUBMITTERS limits apply across all submissions per quorum scope per batch, instead of all submissions per data hash.
We are rearranging the submissions storage map so that it imposes greater limits on the number of submissions per account per batch. In order to apply these changes in a runtime upgrade, we need a storage migration. This change implements this storage migration as multi-block and registers it in the runtime.
tlovell-sxt
force-pushed
the
feat/pallet-migrations
branch
from
e205443 to
d099ed0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
There is an edge case that wasn't accounted for in the current pallet-indexing implementation. While submissions were rejected when an account submitted multiple times for the same batch with the same data, they were not rejected if they submitted multiple times for the same batch with different data. Furthermore, while there was a submission count limit for a single data hash, there was no limit being applied across all submissions for a given batch id. This leads to a potential attack vector, a submitter could submit disagreeing data and increase the storage size for a single batch id as much as they wanted.
This makes a couple changes to handle submission structures and limits better. Firstly, the submissions storage map has been rearranged to enforce some of the desired limitations with typing alone. While before the structure was..
Now, it is
This new mapping makes it so there is only one data hash per submitter per quorum scope per batch.
Furthermore, the extrinsics have been changed so that the MAX_SUBMITTERS limits apply across all submissions per quorum scope per batch, instead of all submissions per data hash.
What changes are included in this PR?
Are these changes tested?
Yes.