Skip to content

modified merge_ranges function per issue: xafs_scan plan, energies are not sorted #328#430

Draft
sterbinsky wants to merge 1 commit intomainfrom
xafs_scan_plan
Draft

modified merge_ranges function per issue: xafs_scan plan, energies are not sorted #328#430
sterbinsky wants to merge 1 commit intomainfrom
xafs_scan_plan

Conversation

@sterbinsky
Copy link
Collaborator

Things to do before merging:

  • add tests
  • write docs
  • update iconfig_testing.toml
  • flake8, black, and isort

@sterbinsky sterbinsky linked an issue Jun 1, 2025 that may be closed by this pull request
@canismarko
Copy link
Contributor

From discussion with @sterbinsky

  • What if ranges at (8300, 8330), (8330.000000001, 8350), etc?
  • what if ranges are out of order?
  • write tests for all these things

Run black src and isort src to make sure the linting will pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

xafs_scan plan, energies are not sorted

2 participants