-
Notifications
You must be signed in to change notification settings - Fork 1
chore(docker): update n8n and Temporal service dependencies in production #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…tion compose file - Added PostgreSQL as a dependency for both n8n and Temporal services in docker-compose.prod.yml to ensure proper service orchestration. - Removed the OpenSearch service configuration to streamline the setup further. These changes enhance the reliability of service dependencies in the production environment.
WalkthroughThe Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant n8n
participant temporal
participant postgresql
User->>n8n: Start service
n8n->>postgresql: Wait for postgresql (depends_on)
User->>temporal: Start service
temporal->>postgresql: Wait for postgresql (depends_on)
Possibly related PRs
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
🔍 Vulnerabilities of
|
| digest | sha256:d6999d22df3b113d90693efce670fd912765b99fae39f475cb6d9e1bc853c8a4 |
| vulnerabilities | |
| platform | linux/amd64 |
| size | 243 MB |
| packages | 1628 |
📦 Base Image node:20-alpine
Description
| ||||||||||||
Description
| ||||||||||||
Description
| ||||||||||||
Description
| ||||||||||||
Description
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
docker-compose.prod.yml (2)
3-4: Confirm removal of Postgres dependency and fix trailing whitespace
Thedepends_on:mapping uses!reset nullto remove the PostgreSQL dependency for the n8n service—please verify that this syntax correctly unsets the dependency in your Compose version. Also, line 3 has trailing whitespace; please remove it to satisfy the linter.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 3-3: trailing spaces
(trailing-spaces)
15-15: Approve removal of the PostgreSQL service declaration
Resetting thepostgresqlservice with!reset nullaligns with the PR objective to externalize the database in production. This change drops the in-repo Postgres service, ensuring an external instance is used.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docker-compose.prod.yml(2 hunks)
🧰 Additional context used
🪛 YAMLlint (1.35.1)
docker-compose.prod.yml
[error] 3-3: trailing spaces
(trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Docker Security Scanning (n8n, Dockerfile.n8n, n8n-test:latest)
🔇 Additional comments (1)
docker-compose.prod.yml (1)
18-19: Confirm removal of Postgres dependency for Temporal service
As with n8n, thedepends_on:block for thetemporalservice has been reset via!reset null. Please verify that this correctly removes the internal dependency and that no residual links to the old service remain.
killev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.



docker-compose.prod.yml.These changes enhance the reliability of service dependencies in the production environment.